Skip to content

Loumir update preview#51

Open
loumir wants to merge 18 commits into
ivoa:mainfrom
loumir:loumir-update_preview
Open

Loumir update preview#51
loumir wants to merge 18 commits into
ivoa:mainfrom
loumir:loumir-update_preview

Conversation

@loumir
Copy link
Copy Markdown
Contributor

@loumir loumir commented May 5, 2026

I am trying to fix the workflow.
let's test first that the document is properly generated . then in the next iterations we can fix the other changes proposed in the various commits.

Copy link
Copy Markdown
Collaborator

@bkhelifi bkhelifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @loumir . There are many interesting inputs.
There are also points to discuss on

Comment thread response_table.tex Outdated
Comment thread response_table.tex Outdated
Comment on lines +13 to +18
\item curation attributes : \emph{resp\_publisher\_did}, \emph{resp\_\_date}
\item identification of the observation it belongs to : \emph{obs\_id}
\item identification of the ObsCore data products it relates to : \emph{obs\_publisher\_did}
\item access : \emph{resp\_access\_url} and \emph{resp\_access\_format}
\item response spatial coverage
\item response energy coverage
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
\item curation attributes : \emph{resp\_publisher\_did}, \emph{resp\_\_date}
\item identification of the observation it belongs to : \emph{obs\_id}
\item identification of the ObsCore data products it relates to : \emph{obs\_publisher\_did}
\item access : \emph{resp\_access\_url} and \emph{resp\_access\_format}
\item response spatial coverage
\item response energy coverage
\item curation attributes : \emph{resp\_publisher\_did}, \emph{resp\_\_date},
\item identification of the observation it belongs to : \emph{obs\_id},
\item identification of the ObsCore data products it relates to : \emph{obs\_publisher\_did},
\item access : \emph{resp\_access\_url} and \emph{resp\_access\_format},
\item response spatial coverage,
\item response energy coverage,
\item response time coverage.

Comment thread Makefile Outdated
Comment thread HighEnergyObsCoreExt.tex
s\_ref\_energy & \ucd{meta.ref;em.energy;pos} & eV & float & {\footnotesize Energy at which the ObsCore spatial characterisation attributes s\_fov , s\_region, s\_resolution are defined} & NO \\
\hline
{\em em\_ref\_oaa\/} & TBD & deg & double & Off-axis angle ({\em i.e.\/}, the angular separation of the target or source from the telescope optical axis) at which the ObsCore spectral characterization attributes {\em em\_res\_power\/}, {\em em\_resolution\/} are defined & NO \\
em\_ref\_energy & \ucd{meta.ref;em.energy;em} & eV & float & {\footnotesize Energy at which the ObsCore spatial characterisation attributes em\_res\_power, em\_resolution are defined} & NO \\
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
em\_ref\_energy & \ucd{meta.ref;em.energy;em} & eV & float & {\footnotesize Energy at which the ObsCore spatial characterisation attributes em\_res\_power, em\_resolution are defined} & NO \\
em\_ref\_energy & \ucd{meta.ref;phys.energy} & eV & float & {\footnotesize Energy at which the ObsCore spectral characterisation attributes em\_res\_power, em\_resolution are defined} & NO \\

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Id.

Comment thread VEPforUCD/VEP-UCD-30-stat-error-sup-inf.txt Outdated
Comment thread HighEnergyObsCoreExt.tex
{\centering \bf Column Name} &{\centering \bf UType} &{\centering \bf Unit} &{\centering \bf Type} &{\centering \bf Description} &{\centering \bf MAN}\\
\hline
{\em ev\_xel\/} & TBD & unitless & integer & Number of events in an event list & NO \\
\begin{longtable}{ | m{2.5cm} | m{4em} | m{3em} | m{3em} | m{6cm} | m{2.3em} |}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not fit a page width. To be changed

Comment thread HighEnergyObsCoreExt.tex
ev\_xel & \ucd{meta.number;obs.event} & unitless & int & {\footnotesize Number of events in an event\_list }& NO \\
\hline
{\em s\_ref\_oaa\/} & TBD & deg & double & Off-axis angle ({\em i.e.\/}, the angular separation of the target or source from the telescope optical axis) at which the ObsCore spatial characterization attributes {\em s\_fov\/}, {\em s\_region\/}, {\em s\_resolution\/} are defined & NO \\
s\_ref\_energy & \ucd{meta.ref;em.energy;pos} & eV & float & {\footnotesize Energy at which the ObsCore spatial characterisation attributes s\_fov , s\_region, s\_resolution are defined} & NO \\
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
s\_ref\_energy & \ucd{meta.ref;em.energy;pos} & eV & float & {\footnotesize Energy at which the ObsCore spatial characterisation attributes s\_fov , s\_region, s\_resolution are defined} & NO \\
s\_ref\_energy & \ucd{meta.ref;phys.energy;pos} & eV & float & {\footnotesize Energy at which the ObsCore spatial characterisation attributes s\_fov , s\_region, s\_resolution are defined} & NO \\

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think em.energy is correct here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so do I.

Comment thread HighEnergyObsCoreExt.tex
s\_ref\_oaa & \ucd{pos.posAng;instr.offset;pos} & deg & float & {\footnotesize Off-axis angle (i.e., the angular separation of the target or source from the telescope optical axis) at which the ObsCore spatial characterisation attributes s\_fov , s\_region, s\_resolution are defined} & NO \\
\hline
{\em energy\_min\/} & TBD & eV & double & Energy associated to the ObsCore attribute {\em em\_max\/}, describing the minimum energy of the dataset & NO \\
em\_ref\_oaa & \ucd{pos.posAng;instr.offset;em} & deg & float & {\footnotesize Off-axis angle (i.e., the angular separation of the target or source from the telescope optical axis) at which the ObsCore spectral characterisation attributes em\_res\_power, em\_resolution are defined} & NO \\
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"pos.posAng;instr.offset;em" or "pos.posAng;instr.offset", because events are not necessary photons...

Comment thread HighEnergyObsCoreExt.tex
t\_intervals & \ucd{?? }& unitless & TMOC & {\footnotesize List of observation intervals or stable/good time intervals describing the exact observation time coverage} & NO \\
\hline
{\em obs\_mode\/} & TBD & unitless & string & Observation mode of an observation & NO \\
energy\_min & \ucd{em.energy;stat.min} & float & eV & {\footnotesize Energy associated to the Obscore attribute em\_max, describing the minimal energy of the dataset} & NO \\
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
energy\_min & \ucd{em.energy;stat.min} & float & eV & {\footnotesize Energy associated to the Obscore attribute em\_max, describing the minimal energy of the dataset} & NO \\
energy\_min & \ucd{phys.energy;stat.min} & float & eV & {\footnotesize Energy associated to the Obscore attribute em\_max, describing the minimal energy of the dataset} & NO \\

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Id.

Comment thread response_table.tex Outdated
@@ -0,0 +1,57 @@

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tex file is not used in the building of the document. What is it used for?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this table summarizes the properties of a data set identified for a response data product. This gathers the minimal set of attributes necessary to select a response file ( for example a PSF file within a set of response file) .
the main selection criteria is based on the ids either of the observation , or of the event-list .

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be added in another paragraph about TAP implementation suggestions.

Action: Addition
Label: psf
Description: A dataset that records the probability density function of
spatial/angular spreading of incident photons from a point source caused
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
spatial/angular spreading of incident photons from a point source caused
spatial/angular spreading of incident particles (e.g., photons) from a point source caused

spatial/angular spreading of incident photons from a point source caused
by the instrument (detector and/or mirror and/or analysis)

Relationships: narrower than #response-function
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be narrower than #pdf ?


Relationships: narrower than #response-function

Used-in: HESS test data release (https://doi.org/10.5281/zenodo.1421099)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Used-in: HESS test data release (https://doi.org/10.5281/zenodo.1421099)
Used-in: HESS test data release (https://doi.org/10.5281/zenodo.1421099), Chandra Source Catalog data product (https://cxc.cfa.harvard.edu/csc/)

Comment on lines +55 to +59
Description: A dataset that records the
combined telescope/instru-
ment effective area and
detector quantum efficiency as
a function of energy
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description: A dataset that records the combined telescope/instrument effective area and
detector quantum efficiency as a function of energy in a NASA OGIP Ancillary Response File compliant format.


Relationships: narrower than #response-function

Used-in: XMM data products ?
Copy link
Copy Markdown
Collaborator

@iannevans iannevans May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Used-in: XMM data products ?
Used-in: Chandra Source Catalog ARF data products (https://cxc.cfa.harvard.edu/csc/), XMM data products

Comment on lines +92 to +93
Description: A dataset that records the probability density function
mapping from energy space into detector pulse height (or position) space
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description: A dataset that records the probability density function mapping from energy space into detector pulse height (or position) space in a NASA OGIP Redistribution Matrix File compliant format.


Relationships: narrower than #response-function

Used-in: Chandra response data products ?
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Used-in: Chandra response data products ?
Used-in: Chandra Source Catalog RMF data products (https://cxc.cfa.harvard.edu/csc/), XMM data products

Comment thread VEPforUCD/VEP-UCD-28-ParticleFluxes.txt Outdated
Additional Property:(dimensionality: [M.T^-3])
Rationale: Distinguish between flux of particles and flux of energy.

Used_in: %todo provide an example site or file
Copy link
Copy Markdown
Collaborator

@iannevans iannevans May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used_in: Chandra Source Catalog (https://cxc.cfa.harvard.edu/csc/) aperture photometry probability density function data product include counts flux, photon (particle) flux, and energy fluxes

Discussion: same as for phys.flux.density
can we use instead "phys.flux;phys.count;em.energy;instr.sr", leading to the removal
of this term of the UCD list? never clear whether we multiply by em.energy or divide...
Isn't phys.flux already per unit of surface area ? Has the same dimensionality as phys.flux.density
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In astronomy, flux, flux density, and flux density surface brightness are all different quantities. Flux is the amount of (energy, particles, ... ) detected from a source per unit time passing through a unit area. The (energy, particles, ...) defines whether it is an energy flux (the default understanding of the term in astronomy unless otherwise specified), particle (most commonly photon) flux, etc. Flux density is the flux per unit in the spectral direction (e.g., per unit frequency, per unit wavelength, per unit energy). Flux density surface brightness is the flux density per unit surface area of the source, if the source is not a point source; so for an extended emission source the surface brightness is typically defined per square arcsec or per square degree.

Used_in: %todo provide an example site or file
Rationale:
????
Discussion: can we use instead "phys.flux;phys.count;instr.sr"?
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see instr.sr in the UCD List, but in any case this is nothing to do with the instrument. It's the distribution over the source resolved are that matters.

Section 5.4. Excess rms-flux correlation

Discussion: TBD in semantics & HEIG
Propose stat.error.below instead of stat.error.negative ( Mireille)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Below" can be ambiguous in cases where the quantity varies with the opposite sign of the measure. For example, as surface brightness increases, the measured surface magnitude decreases.



Discussion:
Propose stat.error.above instead of stat.error.positive ( Mireille & Sebastien)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as for stat.error.below.

Comment thread HighEnergyObsCoreExt.tex
J. Schnabel (ECAP, \href{mailto:jutta.schnabel@fau.de}{jutta.schnabel@fau.de}),
I. Evans (SAO/CXC, \href{mailto:ievans@cfa.harvard.edu}{ievans@cfa.harvard.edu},\\
M. Servillat (LUX - Observatoire de Paris, \href{mailto:mathieu.servillat@obspm.fr}{mathieu.servillat@obspm.fr},\\
B. Khélifi (APC - Université de Paris Cité/CNRS, \href{mailto:khelifi@in2p3.fr}{khelifi@in2p3.fr}),\\
Copy link
Copy Markdown
Collaborator

@iannevans iannevans May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
B. Khélifi (APC - Université de Paris Cité/CNRS, \href{mailto:khelifi@in2p3.fr}{khelifi@in2p3.fr}),\\
B. Kh\'elifi (APC - Universit\'e de Paris Cit\'e/CNRS, \href{mailto:khelifi@in2p3.fr}{khelifi@in2p3.fr}),\\

Comment thread HighEnergyObsCoreExt.tex
M. Servillat (LUX - Observatoire de Paris, \href{mailto:mathieu.servillat@obspm.fr}{mathieu.servillat@obspm.fr},\\
B. Khélifi (APC - Université de Paris Cité/CNRS, \href{mailto:khelifi@in2p3.fr}{khelifi@in2p3.fr}),\\
J. Evans (SAO/CXC, \href{mailto:janet@cfa.harvard.edu}{janet@cfa.harvard.edu}),\\
M. Louys (CDS and ICube - Université de Strasbourg, \href{mailto:mireille.louys@unistra.fr}{mireille.louys@unistra.fr}),\\
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
M. Louys (CDS and ICube - Université de Strasbourg, \href{mailto:mireille.louys@unistra.fr}{mireille.louys@unistra.fr}),\\
M. Louys (CDS and ICube - Universit\'e de Strasbourg, \href{mailto:mireille.louys@unistra.fr}{mireille.louys@unistra.fr}),\\

Comment thread HighEnergyObsCoreExt.tex
C. Boisson (LUX - Observatoire de Paris, \href{mailto:catherine.boisson@obspm.fr}{catherine.boisson@obspm.fr}),\\
M. Cresitello-Dittmar (SAO/CXC, \href{mailto:mdittmar@cfa.harvard.edu}{mdittmar@cfa.harvard.edu}),\\
O. Ates (LUX - ObsParis, \href{mailto:onur.ates@obspm.fr}{onur.ates@obspm.fr}),\\
K. Kosack (IRFU - CEA/Université Paris-Saclay, \href{mailto:karl.kosack@cea.fr}{karl.kosack@cea.fr}),\\
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
K. Kosack (IRFU - CEA/Université Paris-Saclay, \href{mailto:karl.kosack@cea.fr}{karl.kosack@cea.fr}),\\
K. Kosack (IRFU - CEA/Universit\'e Paris-Saclay, \href{mailto:karl.kosack@cea.fr}{karl.kosack@cea.fr}),\\

loumir added 4 commits May 12, 2026 15:07
Removed input for response_table.tex and commented out analysis_dp_table.tex.
Updated the 'Used_in' section with a specific example from the Chandra Source Catalog.
Updated decision statements regarding the use of terms in UCD.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants